Register an OTel attributes reader for each injected/extension class-loader#10930
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomasterfrom Mar 23, 2026
Merged
Conversation
5ab9636 to
62fece3
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 10 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~62fece3d3d, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056012
Total [baseline] (8.84 s) : 0, 8840202
Agent [candidate] (1.058 s) : 0, 1058481
Total [candidate] (8.818 s) : 0, 8818304
section iast
Agent [baseline] (1.233 s) : 0, 1233038
Total [baseline] (9.571 s) : 0, 9570652
Agent [candidate] (1.23 s) : 0, 1229770
Total [candidate] (9.58 s) : 0, 9580487
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~62fece3d3d, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.197 ms) : 0, 1197
BytebuddyAgent [baseline] (629.127 ms) : 0, 629127
BytebuddyAgent [candidate] (629.829 ms) : 0, 629829
AgentMeter [baseline] (29.363 ms) : 0, 29363
AgentMeter [candidate] (29.427 ms) : 0, 29427
GlobalTracer [baseline] (256.805 ms) : 0, 256805
GlobalTracer [candidate] (257.727 ms) : 0, 257727
AppSec [baseline] (31.766 ms) : 0, 31766
AppSec [candidate] (31.748 ms) : 0, 31748
Debugger [baseline] (59.708 ms) : 0, 59708
Debugger [candidate] (59.658 ms) : 0, 59658
Remote Config [baseline] (581.865 µs) : 0, 582
Remote Config [candidate] (582.791 µs) : 0, 583
Telemetry [baseline] (7.993 ms) : 0, 7993
Telemetry [candidate] (8.793 ms) : 0, 8793
Flare Poller [baseline] (3.52 ms) : 0, 3520
Flare Poller [candidate] (3.567 ms) : 0, 3567
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (801.291 ms) : 0, 801291
BytebuddyAgent [candidate] (798.426 ms) : 0, 798426
AgentMeter [baseline] (11.647 ms) : 0, 11647
AgentMeter [candidate] (11.427 ms) : 0, 11427
GlobalTracer [baseline] (247.525 ms) : 0, 247525
GlobalTracer [candidate] (247.849 ms) : 0, 247849
AppSec [baseline] (26.507 ms) : 0, 26507
AppSec [candidate] (26.462 ms) : 0, 26462
Debugger [baseline] (67.615 ms) : 0, 67615
Debugger [candidate] (68.556 ms) : 0, 68556
Remote Config [baseline] (528.368 µs) : 0, 528
Remote Config [candidate] (531.843 µs) : 0, 532
Telemetry [baseline] (11.337 ms) : 0, 11337
Telemetry [candidate] (10.235 ms) : 0, 10235
Flare Poller [baseline] (3.979 ms) : 0, 3979
Flare Poller [candidate] (3.678 ms) : 0, 3678
IAST [baseline] (25.294 ms) : 0, 25294
IAST [candidate] (25.34 ms) : 0, 25340
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~62fece3d3d, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058778
Total [baseline] (11.061 s) : 0, 11061391
Agent [candidate] (1.067 s) : 0, 1066836
Total [candidate] (11.102 s) : 0, 11102478
section appsec
Agent [baseline] (1.247 s) : 0, 1246614
Total [baseline] (11.146 s) : 0, 11145842
Agent [candidate] (1.25 s) : 0, 1250218
Total [candidate] (11.092 s) : 0, 11091604
section iast
Agent [baseline] (1.231 s) : 0, 1230533
Total [baseline] (11.339 s) : 0, 11338959
Agent [candidate] (1.238 s) : 0, 1237812
Total [candidate] (11.377 s) : 0, 11377365
section profiling
Agent [baseline] (1.193 s) : 0, 1193217
Total [baseline] (11.063 s) : 0, 11063008
Agent [candidate] (1.189 s) : 0, 1189249
Total [candidate] (11.037 s) : 0, 11036810
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~62fece3d3d, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (630.111 ms) : 0, 630111
BytebuddyAgent [candidate] (634.452 ms) : 0, 634452
AgentMeter [baseline] (29.374 ms) : 0, 29374
AgentMeter [candidate] (29.538 ms) : 0, 29538
GlobalTracer [baseline] (257.182 ms) : 0, 257182
GlobalTracer [candidate] (259.064 ms) : 0, 259064
AppSec [baseline] (31.736 ms) : 0, 31736
AppSec [candidate] (31.938 ms) : 0, 31938
Debugger [baseline] (60.406 ms) : 0, 60406
Debugger [candidate] (60.729 ms) : 0, 60729
Remote Config [baseline] (584.304 µs) : 0, 584
Remote Config [candidate] (584.381 µs) : 0, 584
Telemetry [baseline] (7.981 ms) : 0, 7981
Telemetry [candidate] (8.821 ms) : 0, 8821
Flare Poller [baseline] (4.308 ms) : 0, 4308
Flare Poller [candidate] (4.333 ms) : 0, 4333
section appsec
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (658.689 ms) : 0, 658689
BytebuddyAgent [candidate] (660.177 ms) : 0, 660177
AgentMeter [baseline] (12.049 ms) : 0, 12049
AgentMeter [candidate] (12.101 ms) : 0, 12101
GlobalTracer [baseline] (258.087 ms) : 0, 258087
GlobalTracer [candidate] (259.036 ms) : 0, 259036
AppSec [baseline] (177.808 ms) : 0, 177808
AppSec [candidate] (178.093 ms) : 0, 178093
Debugger [baseline] (65.885 ms) : 0, 65885
Debugger [candidate] (66.562 ms) : 0, 66562
Remote Config [baseline] (630.07 µs) : 0, 630
Remote Config [candidate] (640.721 µs) : 0, 641
Telemetry [baseline] (8.365 ms) : 0, 8365
Telemetry [candidate] (8.383 ms) : 0, 8383
Flare Poller [baseline] (3.597 ms) : 0, 3597
Flare Poller [candidate] (3.587 ms) : 0, 3587
IAST [baseline] (24.139 ms) : 0, 24139
IAST [candidate] (24.261 ms) : 0, 24261
section iast
crashtracking [baseline] (1.217 ms) : 0, 1217
crashtracking [candidate] (1.205 ms) : 0, 1205
BytebuddyAgent [baseline] (798.113 ms) : 0, 798113
BytebuddyAgent [candidate] (803.857 ms) : 0, 803857
AgentMeter [baseline] (11.4 ms) : 0, 11400
AgentMeter [candidate] (11.695 ms) : 0, 11695
GlobalTracer [baseline] (247.878 ms) : 0, 247878
GlobalTracer [candidate] (248.459 ms) : 0, 248459
AppSec [baseline] (26.436 ms) : 0, 26436
AppSec [candidate] (27.415 ms) : 0, 27415
Debugger [baseline] (71.19 ms) : 0, 71190
Debugger [candidate] (68.955 ms) : 0, 68955
Remote Config [baseline] (535.682 µs) : 0, 536
Remote Config [candidate] (535.586 µs) : 0, 536
Telemetry [baseline] (9.177 ms) : 0, 9177
Telemetry [candidate] (10.444 ms) : 0, 10444
Flare Poller [baseline] (3.34 ms) : 0, 3340
Flare Poller [candidate] (3.566 ms) : 0, 3566
IAST [baseline] (25.27 ms) : 0, 25270
IAST [candidate] (25.42 ms) : 0, 25420
section profiling
crashtracking [baseline] (1.178 ms) : 0, 1178
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (689.676 ms) : 0, 689676
BytebuddyAgent [candidate] (687.724 ms) : 0, 687724
AgentMeter [baseline] (9.087 ms) : 0, 9087
AgentMeter [candidate] (9.025 ms) : 0, 9025
GlobalTracer [baseline] (217.512 ms) : 0, 217512
GlobalTracer [candidate] (216.39 ms) : 0, 216390
AppSec [baseline] (32.317 ms) : 0, 32317
AppSec [candidate] (32.229 ms) : 0, 32229
Debugger [baseline] (65.394 ms) : 0, 65394
Debugger [candidate] (65.242 ms) : 0, 65242
Remote Config [baseline] (620.016 µs) : 0, 620
Remote Config [candidate] (562.57 µs) : 0, 563
Telemetry [baseline] (7.701 ms) : 0, 7701
Telemetry [candidate] (7.724 ms) : 0, 7724
Flare Poller [baseline] (4.265 ms) : 0, 4265
Flare Poller [candidate] (4.255 ms) : 0, 4255
ProfilingAgent [baseline] (94.057 ms) : 0, 94057
ProfilingAgent [candidate] (93.765 ms) : 0, 93765
Profiling [baseline] (94.616 ms) : 0, 94616
Profiling [candidate] (94.316 ms) : 0, 94316
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~62fece3d3d, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section baseline
no_agent (1.183 ms) : 1171, 1194
. : milestone, 1183,
iast (3.067 ms) : 3026, 3109
. : milestone, 3067,
iast_FULL (5.942 ms) : 5883, 6002
. : milestone, 5942,
iast_GLOBAL (3.556 ms) : 3499, 3612
. : milestone, 3556,
profiling (1.945 ms) : 1929, 1961
. : milestone, 1945,
tracing (1.834 ms) : 1819, 1850
. : milestone, 1834,
section candidate
no_agent (1.205 ms) : 1193, 1217
. : milestone, 1205,
iast (3.179 ms) : 3139, 3219
. : milestone, 3179,
iast_FULL (5.666 ms) : 5609, 5722
. : milestone, 5666,
iast_GLOBAL (3.468 ms) : 3405, 3531
. : milestone, 3468,
profiling (2.012 ms) : 1996, 2028
. : milestone, 2012,
tracing (1.816 ms) : 1800, 1831
. : milestone, 1816,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~62fece3d3d, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section baseline
no_agent (18.941 ms) : 18748, 19133
. : milestone, 18941,
appsec (18.324 ms) : 18141, 18507
. : milestone, 18324,
code_origins (17.883 ms) : 17704, 18062
. : milestone, 17883,
iast (17.763 ms) : 17584, 17943
. : milestone, 17763,
profiling (18.667 ms) : 18477, 18856
. : milestone, 18667,
tracing (17.804 ms) : 17624, 17984
. : milestone, 17804,
section candidate
no_agent (17.875 ms) : 17692, 18058
. : milestone, 17875,
appsec (18.454 ms) : 18265, 18643
. : milestone, 18454,
code_origins (17.807 ms) : 17628, 17986
. : milestone, 17807,
iast (18.735 ms) : 18546, 18924
. : milestone, 18735,
profiling (18.57 ms) : 18383, 18757
. : milestone, 18570,
tracing (17.484 ms) : 17311, 17656
. : milestone, 17484,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~62fece3d3d, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section baseline
no_agent (15.425 s) : 15425000, 15425000
. : milestone, 15425000,
appsec (14.851 s) : 14851000, 14851000
. : milestone, 14851000,
iast (18.325 s) : 18325000, 18325000
. : milestone, 18325000,
iast_GLOBAL (17.484 s) : 17484000, 17484000
. : milestone, 17484000,
profiling (15.137 s) : 15137000, 15137000
. : milestone, 15137000,
tracing (15.035 s) : 15035000, 15035000
. : milestone, 15035000,
section candidate
no_agent (14.99 s) : 14990000, 14990000
. : milestone, 14990000,
appsec (14.805 s) : 14805000, 14805000
. : milestone, 14805000,
iast (18.393 s) : 18393000, 18393000
. : milestone, 18393000,
iast_GLOBAL (17.942 s) : 17942000, 17942000
. : milestone, 17942000,
profiling (14.895 s) : 14895000, 14895000
. : milestone, 14895000,
tracing (14.908 s) : 14908000, 14908000
. : milestone, 14908000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~62fece3d3d, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1490
. : milestone, 1478,
appsec (3.823 ms) : 3602, 4043
. : milestone, 3823,
iast (2.28 ms) : 2210, 2350
. : milestone, 2280,
iast_GLOBAL (2.317 ms) : 2247, 2387
. : milestone, 2317,
profiling (2.103 ms) : 2048, 2158
. : milestone, 2103,
tracing (2.075 ms) : 2021, 2129
. : milestone, 2075,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (3.824 ms) : 3601, 4047
. : milestone, 3824,
iast (2.273 ms) : 2204, 2343
. : milestone, 2273,
iast_GLOBAL (2.307 ms) : 2237, 2376
. : milestone, 2307,
profiling (2.131 ms) : 2074, 2189
. : milestone, 2131,
tracing (2.083 ms) : 2029, 2137
. : milestone, 2083,
|
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Each class-loader where we inject/use
OtelMeterProviderwill have its own version of theAttributesclass, for example the copy on the bootstrap used for extensions vs. the copy injected for applications using the OTel API.When creating a new
OtelMeterProviderwe now register the appropriate reader to extract attribute keys and values.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.